refactor: 拆分媒体上传职责并锁定API路由
This commit is contained in:
1 parent
6f18c67315
commit
2ad009f5c0
8 files changed
+375
-171
No files matched your search
@@ -0,0 +1,83 @@
|
||||
import assert from "node:assert/strict";
|
||||
import { mkdtemp, readFile, rm } from "node:fs/promises";
|
||||
import { tmpdir } from "node:os";
|
||||
import path from "node:path";
|
||||
import { test } from "node:test";
|
||||
import { BadRequestException } from "@nestjs/common";
|
||||
import { AdminUploadService } from "../src/modules/admin/admin-upload.service.js";
|
||||
|
||||
const environmentKeys = [
|
||||
"OBJECT_STORAGE_BUCKET",
|
||||
"OBJECT_STORAGE_ACCESS_KEY",
|
||||
"OBJECT_STORAGE_SECRET_KEY",
|
||||
"LOCAL_MEDIA_ROOT",
|
||||
"LOCAL_MEDIA_BASE_URL",
|
||||
] as const;
|
||||
|
||||
test("local mode reports configuration and returns a relative local upload URL", async () => {
|
||||
const original = saveEnvironment();
|
||||
const mediaRoot = await mkdtemp(path.join(tmpdir(), "personal-brand-uploads-"));
|
||||
process.env.LOCAL_MEDIA_ROOT = mediaRoot;
|
||||
process.env.LOCAL_MEDIA_BASE_URL = "/uploads";
|
||||
try {
|
||||
const service = new AdminUploadService();
|
||||
assert.deepEqual(await service.getConfiguration(), {
|
||||
configured: true,
|
||||
status: "ok",
|
||||
mode: "local",
|
||||
});
|
||||
const result = await service.presign({
|
||||
fileName: "case study.png",
|
||||
contentType: "image/png",
|
||||
scope: "trust",
|
||||
});
|
||||
assert.match(result.key, /^\d{4}\/[a-f0-9]{16}\.png$/);
|
||||
assert.equal(result.uploadUrl, `/admin/uploads/local?key=${encodeURIComponent(result.key)}`);
|
||||
assert.equal(result.publicUrl, `/uploads/${result.key}`);
|
||||
assert.equal(result.mode, "local");
|
||||
await service.saveLocal(result.key, "image/png", Buffer.from("image-data"));
|
||||
assert.equal(await readFile(path.join(mediaRoot, result.key), "utf8"), "image-data");
|
||||
} finally {
|
||||
await rm(mediaRoot, { recursive: true, force: true });
|
||||
restoreEnvironment(original);
|
||||
}
|
||||
});
|
||||
|
||||
test("upload service validates media type and traversal keys before persistence", async () => {
|
||||
const original = saveEnvironment();
|
||||
const mediaRoot = await mkdtemp(path.join(tmpdir(), "personal-brand-uploads-"));
|
||||
process.env.LOCAL_MEDIA_ROOT = mediaRoot;
|
||||
try {
|
||||
const service = new AdminUploadService();
|
||||
await assert.rejects(
|
||||
() => service.presign({ fileName: "document.pdf", contentType: "application/pdf" }),
|
||||
BadRequestException,
|
||||
);
|
||||
await assert.rejects(
|
||||
() => service.saveLocal("../2026/evil.png", "image/png", Buffer.from("evil")),
|
||||
BadRequestException,
|
||||
);
|
||||
await assert.rejects(
|
||||
() => service.saveLocal("2026/photo.jpg", "image/png", Buffer.from("mismatch")),
|
||||
BadRequestException,
|
||||
);
|
||||
await assert.rejects(
|
||||
() => service.saveLocal("2026/photo.png", "application/pdf", Buffer.from("mismatch")),
|
||||
BadRequestException,
|
||||
);
|
||||
} finally {
|
||||
await rm(mediaRoot, { recursive: true, force: true });
|
||||
restoreEnvironment(original);
|
||||
}
|
||||
});
|
||||
|
||||
function saveEnvironment(): Record<(typeof environmentKeys)[number], string | undefined> {
|
||||
return Object.fromEntries(environmentKeys.map((key) => [key, process.env[key]]));
|
||||
}
|
||||
|
||||
function restoreEnvironment(values: Record<string, string | undefined>): void {
|
||||
for (const key of environmentKeys) {
|
||||
if (values[key] === undefined) delete process.env[key];
|
||||
else process.env[key] = values[key];
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,87 @@
|
||||
import assert from "node:assert/strict";
|
||||
import { test } from "node:test";
|
||||
import "reflect-metadata";
|
||||
import { RequestMethod } from "@nestjs/common";
|
||||
import { MetadataScanner } from "@nestjs/core";
|
||||
import { AppModule } from "../src/app.module.js";
|
||||
import { AdminUploadController } from "../src/modules/admin/admin-upload.controller.js";
|
||||
import { AdminLocalUploadController } from "../src/modules/admin/admin-local-upload.controller.js";
|
||||
import { AdminWorkspacePreviewController } from "../src/modules/workspace/admin-workspace-preview.controller.js";
|
||||
import { AdminTemplateController } from "../src/modules/workspace/admin-template.controller.js";
|
||||
import { AdminCapabilityController } from "../src/modules/workspace/admin-capability.controller.js";
|
||||
import { AdminOfferingController } from "../src/modules/workspace/admin-offering.controller.js";
|
||||
import { AdminInquiryController } from "../src/modules/workspace/admin-inquiry.controller.js";
|
||||
|
||||
const expectedRoutes = new Set([
|
||||
"GET /admin/workspace",
|
||||
"GET /admin/workspace/preview",
|
||||
"POST /admin/workspace/install",
|
||||
"GET /admin/workspace/template/preview",
|
||||
"POST /admin/workspace/template/upgrade",
|
||||
"POST /admin/workspace/template/rollback",
|
||||
"GET /admin/workspace/capabilities",
|
||||
"GET /admin/workspace/sample-content/preview",
|
||||
"POST /admin/workspace/sample-content/import",
|
||||
"PATCH /admin/workspace/capabilities/:key",
|
||||
"GET /admin/workspace/offerings",
|
||||
"POST /admin/workspace/offerings",
|
||||
"PATCH /admin/workspace/offerings/:id",
|
||||
"DELETE /admin/workspace/offerings/:id",
|
||||
"POST /admin/workspace/fields",
|
||||
"PATCH /admin/workspace/fields/:id",
|
||||
"DELETE /admin/workspace/fields/:id",
|
||||
"GET /admin/workspace/forms",
|
||||
"GET /admin/workspace/submissions",
|
||||
"PATCH /admin/workspace/submissions/:id",
|
||||
"POST /admin/workspace/forms",
|
||||
"PATCH /admin/workspace/forms/:id",
|
||||
"GET /admin/uploads/config",
|
||||
"POST /admin/uploads/presign",
|
||||
"PUT /admin/uploads/local",
|
||||
]);
|
||||
|
||||
test("refactored admin controllers preserve their declared API routes", () => {
|
||||
const controllers = [
|
||||
AdminWorkspacePreviewController,
|
||||
AdminTemplateController,
|
||||
AdminCapabilityController,
|
||||
AdminOfferingController,
|
||||
AdminInquiryController,
|
||||
AdminUploadController,
|
||||
AdminLocalUploadController,
|
||||
];
|
||||
const scanner = new MetadataScanner();
|
||||
const routes = controllers.flatMap((controller) =>
|
||||
scanner.scanFromPrototype(controller, controller.prototype, (methodName) => {
|
||||
const handler = controller.prototype[methodName];
|
||||
const method = Reflect.getMetadata("method", handler);
|
||||
assert.ok(
|
||||
method !== undefined,
|
||||
`Missing HTTP method metadata on ${controller.name}.${methodName}`,
|
||||
);
|
||||
const httpMethod = RequestMethod[method];
|
||||
const controllerPath = Reflect.getMetadata("path", controller);
|
||||
const handlerPath = Reflect.getMetadata("path", handler);
|
||||
const routePath = `/${controllerPath}/${handlerPath ?? ""}`
|
||||
.replace(/\/+$/, "")
|
||||
.replace(/\/$/, "");
|
||||
return `${httpMethod} ${routePath}`;
|
||||
}),
|
||||
);
|
||||
assert.deepEqual([...routes].sort(), [...expectedRoutes].sort());
|
||||
});
|
||||
|
||||
test("root module composes bounded feature modules only", () => {
|
||||
const imports = Reflect.getMetadata("imports", AppModule) ?? [];
|
||||
const names = imports.map((item) => item.name);
|
||||
assert.deepEqual(names, [
|
||||
"InfrastructureModule",
|
||||
"PublicModule",
|
||||
"CustomerModule",
|
||||
"SessionModule",
|
||||
"TenantModule",
|
||||
"WorkspaceModule",
|
||||
"AdminModule",
|
||||
"HealthModule",
|
||||
]);
|
||||
});
|
||||
@@ -5,7 +5,7 @@ import path from "node:path";
|
||||
import test from "node:test";
|
||||
|
||||
test("upload presign DTO rejects unsupported media type and oversized names", async () => {
|
||||
const { PresignUploadDto } = await import("../dist/modules/admin/admin-upload.controller.js");
|
||||
const { PresignUploadDto } = await import("../dist/modules/admin/admin-upload.dto.js");
|
||||
const validator = await import("class-validator");
|
||||
const invalid = new PresignUploadDto();
|
||||
invalid.fileName = "x".repeat(256);
|
||||
@@ -23,6 +23,7 @@ test("upload presign DTO rejects unsupported media type and oversized names", as
|
||||
test("local upload presign targets the API route and requires brand access", async () => {
|
||||
const { AdminUploadController } =
|
||||
await import("../dist/modules/admin/admin-upload.controller.js");
|
||||
const { AdminUploadService } = await import("../dist/modules/admin/admin-upload.service.js");
|
||||
const mediaRoot = await mkdtemp(path.join(os.tmpdir(), "personal-brand-upload-"));
|
||||
const previousRoot = process.env.LOCAL_MEDIA_ROOT;
|
||||
const previousBucket = process.env.OBJECT_STORAGE_BUCKET;
|
||||
@@ -34,7 +35,7 @@ test("local upload presign targets the API route and requires brand access", asy
|
||||
delete process.env.OBJECT_STORAGE_ACCESS_KEY;
|
||||
delete process.env.OBJECT_STORAGE_SECRET_KEY;
|
||||
try {
|
||||
const controller = new AdminUploadController(access);
|
||||
const controller = new AdminUploadController(access, new AdminUploadService());
|
||||
const result = await controller.presign(
|
||||
{},
|
||||
{ fileName: "portrait.jpg", contentType: "image/jpeg" },
|
||||
|
||||
Reference in new issue
Block a user