refactor: 将数据库访问从控制器下沉到服务层

This commit is contained in:
que01 committed 2026-10-14 17:53:49 +08:00
1 parent f158f906d5
commit 3ae7b462f5
21 files changed
+1046 -857

No files matched your search

@@ -1,8 +1,6 @@
import {
Controller,
BadRequestException,
Body,
ConflictException,
ForbiddenException,
Get,
Param,
@@ -12,30 +10,23 @@ import {
UnauthorizedException,
} from "@nestjs/common";
import type { FastifyRequest } from "fastify";
import { PrismaService } from "../../prisma.service.js";
import { readIdentity, signIdentity } from "../../auth.js";
import { readIdentity } from "../../auth.js";
import { AdminAccessService } from "../../admin-access.service.js";
import { CreateBrandMemberDto, UpdateBrandMemberDto } from "../../admin.dto.js";
import bcrypt from "bcryptjs";
import { TenantService } from "./tenant.service.js";
@Controller("admin/brands")
export class TenantController {
constructor(
private readonly prisma: PrismaService,
private readonly access: AdminAccessService,
private readonly tenants: TenantService,
) {}
@Get("members")
async listMembers(@Req() request: FastifyRequest): Promise<unknown> {
await this.access.requireRole(request, ["owner", "admin", "platform-admin"]);
const current = this.adminIdentity(request);
return this.prisma.brandMembership.findMany({
where: { brandId: current.brandId },
include: {
adminUser: { select: { id: true, username: true, displayName: true, isEnabled: true } },
},
orderBy: { createdAt: "asc" },
});
return this.tenants.listMembers(current.brandId);
}
@Post("members")
@@ -45,36 +36,7 @@ export class TenantController {
): Promise<unknown> {
await this.access.requireRole(request, ["owner", "admin", "platform-admin"]);
const actor = this.adminIdentity(request);
const username = body.username.trim();
const displayName = body.displayName.trim();
if (!username || !displayName) throw new BadRequestException("账号和显示名称不能为空");
const existing = await this.prisma.adminUser.findUnique({ where: { username } });
if (existing) throw new ConflictException("账号已存在,请使用其他账号");
const passwordHash = await bcrypt.hash(body.password, 12);
const member = await this.prisma.$transaction(async (tx) => {
const adminUser = await tx.adminUser.create({
data: {
username,
displayName,
passwordHash,
role: "admin",
isEnabled: true,
mustChangePassword: true,
},
});
return tx.brandMembership.create({
data: {
adminUserId: adminUser.id,
brandId: actor.brandId,
role: body.role,
isEnabled: true,
},
include: {
adminUser: { select: { id: true, username: true, displayName: true, isEnabled: true } },
},
});
});
return member;
return this.tenants.createMember(actor.brandId, body);
}
@Patch("members/:id")
@@ -85,43 +47,13 @@ export class TenantController {
): Promise<unknown> {
await this.access.requireRole(request, ["owner", "admin", "platform-admin"]);
const actor = this.adminIdentity(request);
const membership = await this.prisma.brandMembership.findFirst({
where: { id, brandId: actor.brandId },
});
if (!membership) throw new BadRequestException("成员不存在");
if (membership.adminUserId === actor.subject) {
if (body.isEnabled === false || (body.role && body.role !== membership.role)) {
throw new BadRequestException("不能修改自己的角色或停用自己");
}
}
const nextRole = body.role ?? membership.role;
const nextEnabled = body.isEnabled ?? membership.isEnabled;
if (membership.role === "owner" && (nextRole !== "owner" || !nextEnabled)) {
const ownerCount = await this.prisma.brandMembership.count({
where: { brandId: actor.brandId, role: "owner", isEnabled: true },
});
if (ownerCount <= 1) throw new BadRequestException("品牌至少需要保留一位启用的负责人");
}
return this.prisma.brandMembership.update({
where: { id: membership.id },
data: {
...(body.role ? { role: body.role } : {}),
...(body.isEnabled === undefined ? {} : { isEnabled: body.isEnabled }),
},
include: {
adminUser: { select: { id: true, username: true, displayName: true, isEnabled: true } },
},
});
return this.tenants.updateMember(actor.brandId, actor.subject, id, body);
}
@Get()
async list(@Req() request: FastifyRequest): Promise<unknown> {
const identity = this.adminIdentity(request);
return this.prisma.brandMembership.findMany({
where: { adminUserId: identity.subject, isEnabled: true },
include: { brand: { select: { id: true, slug: true, name: true, templateKey: true } } },
orderBy: { createdAt: "asc" },
});
return this.tenants.listMemberships(identity.subject);
}
@Post(":brandId/switch")
@@ -130,15 +62,7 @@ export class TenantController {
@Param("brandId") brandId: string,
): Promise<{ token: string; brand: unknown }> {
const identity = this.adminIdentity(request);
const membership = await this.prisma.brandMembership.findFirst({
where: { adminUserId: identity.subject, brandId, isEnabled: true },
include: { brand: { select: { id: true, slug: true, name: true, templateKey: true } } },
});
if (!membership) throw new ForbiddenException("没有该品牌的管理权限");
return {
token: signIdentity({ subject: identity.subject, brandId, role: "admin" }),
brand: membership.brand,
};
return this.tenants.switchBrand(identity, brandId);
}
private adminIdentity(request: FastifyRequest) {
@@ -0,0 +1,114 @@
import {
BadRequestException,
ConflictException,
ForbiddenException,
Injectable,
} from "@nestjs/common";
import bcrypt from "bcryptjs";
import { PrismaService } from "../../prisma.service.js";
import { readIdentity, signIdentity } from "../../auth.js";
import type { CreateBrandMemberDto, UpdateBrandMemberDto } from "../../admin.dto.js";
type AdminIdentity = ReturnType<typeof readIdentity>;
@Injectable()
export class TenantService {
constructor(private readonly prisma: PrismaService) {}
listMembers(brandId: string) {
return this.prisma.brandMembership.findMany({
where: { brandId },
include: {
adminUser: { select: { id: true, username: true, displayName: true, isEnabled: true } },
},
orderBy: { createdAt: "asc" },
});
}
async createMember(brandId: string, body: CreateBrandMemberDto) {
const username = body.username.trim();
const displayName = body.displayName.trim();
if (!username || !displayName) throw new BadRequestException("账号和显示名称不能为空");
const existing = await this.prisma.adminUser.findUnique({ where: { username } });
if (existing) throw new ConflictException("账号已存在,请使用其他账号");
const passwordHash = await bcrypt.hash(body.password, 12);
return this.prisma.$transaction(async (tx) => {
const adminUser = await tx.adminUser.create({
data: {
username,
displayName,
passwordHash,
role: "admin",
isEnabled: true,
mustChangePassword: true,
},
});
return tx.brandMembership.create({
data: {
adminUserId: adminUser.id,
brandId,
role: body.role,
isEnabled: true,
},
include: {
adminUser: { select: { id: true, username: true, displayName: true, isEnabled: true } },
},
});
});
}
async updateMember(
brandId: string,
actorSubject: string,
id: string,
body: UpdateBrandMemberDto,
) {
const membership = await this.prisma.brandMembership.findFirst({
where: { id, brandId },
});
if (!membership) throw new BadRequestException("成员不存在");
if (membership.adminUserId === actorSubject) {
if (body.isEnabled === false || (body.role && body.role !== membership.role)) {
throw new BadRequestException("不能修改自己的角色或停用自己");
}
}
const nextRole = body.role ?? membership.role;
const nextEnabled = body.isEnabled ?? membership.isEnabled;
if (membership.role === "owner" && (nextRole !== "owner" || !nextEnabled)) {
const ownerCount = await this.prisma.brandMembership.count({
where: { brandId, role: "owner", isEnabled: true },
});
if (ownerCount <= 1) throw new BadRequestException("品牌至少需要保留一位启用的负责人");
}
return this.prisma.brandMembership.update({
where: { id: membership.id },
data: {
...(body.role ? { role: body.role } : {}),
...(body.isEnabled === undefined ? {} : { isEnabled: body.isEnabled }),
},
include: {
adminUser: { select: { id: true, username: true, displayName: true, isEnabled: true } },
},
});
}
listMemberships(subject: string) {
return this.prisma.brandMembership.findMany({
where: { adminUserId: subject, isEnabled: true },
include: { brand: { select: { id: true, slug: true, name: true, templateKey: true } } },
orderBy: { createdAt: "asc" },
});
}
async switchBrand(identity: AdminIdentity, brandId: string) {
const membership = await this.prisma.brandMembership.findFirst({
where: { adminUserId: identity.subject, brandId, isEnabled: true },
include: { brand: { select: { id: true, slug: true, name: true, templateKey: true } } },
});
if (!membership) throw new ForbiddenException("没有该品牌的管理权限");
return {
token: signIdentity({ subject: identity.subject, brandId, role: "admin" }),
brand: membership.brand,
};
}
}